beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1130: [BEAM-27] Add parsing and validation of @...
Date Tue, 18 Oct 2016 22:29:28 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1130

    [BEAM-27] Add parsing and validation of @StateId params to @ProcessElement

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @bjchambers @jkff 
    
    This is an initial draft to discuss some design decisions along the way.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam State-params

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1130
    
----
commit 33c884118ed04c0a008ef6018a06fa336a866de8
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-14T17:51:57Z

    Use the correct State class in DoFnSignatures

commit 81b6994bf8162bfc3aaba40a708ce8385be76d80
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-14T18:07:55Z

    Add analysis and validation of State parameters to DoFn.ProcessElement

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message