beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-498) Make DoFnWithContext the new DoFn
Date Sat, 12 Nov 2016 05:04:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15659025#comment-15659025
] 

ASF GitHub Bot commented on BEAM-498:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1355

    [BEAM-498] Treat ProcessContext and Context like other DoFn parameters

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Before this change, `ProcessContext` and `Context` were special-cased, while other parameters
were treated generically. After this change, all parameters receive the same dynamic treatment.
Thus a user need not request these parameters, the runner can save the effort of constructing
them, and we can migrate towards less "all-in-one" parameters.
    
    I changed only the analysis and code generation a bit to remove special casing, but did
not write new delegations that would actually add dynamic parameter generation to methods
that do not already have them, so only `@ProcessElement` and `@OnTimer` are affected.
    
    Posted for self-review & signposting.
    
    CC: @tgroh who has discussed this and @jkff who may have interest.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam ProcessContext

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1355
    
----
commit 959e906a7591eaa40c3c2451f0c3dcfdffc50c32
Author: Kenneth Knowles <klk@google.com>
Date:   2016-11-11T22:55:16Z

    Treat ProcessContext and Context like other DoFn parameters
    
    Before this change, ProcessContext and Context were special-cased, while
    other parameters were treated generically. After this change, all parameters
    receive the same dynamic treatment. Thus a user need not request these
    parameters, the runner can save the effort of constructing them, and we
    can migrate towards less "all-in-one" parameters.

----


> Make DoFnWithContext the new DoFn
> ---------------------------------
>
>                 Key: BEAM-498
>                 URL: https://issues.apache.org/jira/browse/BEAM-498
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message