beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-498) Make DoFnWithContext the new DoFn
Date Tue, 15 Nov 2016 06:22:59 GMT


ASF GitHub Bot commented on BEAM-498:

GitHub user kennknowles opened a pull request:

    [BEAM-498] Rename DoFn.ExtraContextFactory to DoFn.Arguments

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @bjchambers 
    I think we've discussed this before. Big picture: now we can treat all dynamic methods
uniformly, and use `DoFnSignatures` and `ParDo` to do the needed validation. I think since
all arguments to methods fall into the "extra" category, we can save some typing and use more
conventional vocabulary.

You can merge this pull request into a Git repository by running:

    $ git pull Arguments

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1360
commit 4afc16fad9eeaeee1d640822000da6a1062c4056
Author: Kenneth Knowles <>
Date:   2016-11-15T06:19:35Z

    Rename DoFn.ExtraContextFactory to DoFn.Arguments


> Make DoFnWithContext the new DoFn
> ---------------------------------
>                 Key: BEAM-498
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible

This message was sent by Atlassian JIRA

View raw message