beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-646) Get runners out of the apply()
Date Wed, 30 Nov 2016 21:53:59 GMT

    [ https://issues.apache.org/jira/browse/BEAM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709899#comment-15709899
] 

ASF GitHub Bot commented on BEAM-646:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1469

    [BEAM-646] Move TransformHierarchy Maintenance into it

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This reduces the complexity of Pipeline.applyInternal by keeping the
    responsiblities to passing a node into the Transform Hierarchy,
    enforcing name uniqueness, and causing the runner to expand the
    PTransform. This logic is moved to the appropriate application sites.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam transform_hierarchy_maintenance_internally

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1469
    
----
commit ae6ac672e582148b846c3910cc7247700b3403cb
Author: Thomas Groh <tgroh@google.com>
Date:   2016-11-29T22:29:47Z

    Move TransformHierarchy Maintenance into it
    
    This reduces the complexity of Pipeline.applyInternal by keeping the
    responsiblities to passing a node into the Transform Hierarchy,
    enforcing name uniqueness, and causing the runner to expand the
    PTransform. This logic is moved to the appropriate application sites.

----


> Get runners out of the apply()
> ------------------------------
>
>                 Key: BEAM-646
>                 URL: https://issues.apache.org/jira/browse/BEAM-646
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>
> Right now, the runner intercepts calls to apply() and replaces transforms as we go. This
means that there is no "original" user graph. For portability and misc architectural benefits,
we would like to build the original graph first, and have the runner override later.
> Some runners already work in this manner, but we could integrate it more smoothly, with
more validation, via some handy APIs on e.g. the Pipeline object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message