beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-694) TriggerTester doesn't test timer firings
Date Fri, 04 Nov 2016 18:11:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637215#comment-15637215
] 

Kenneth Knowles commented on BEAM-694:
--------------------------------------

+1

Triggers set timers, but do not receive callbacks. And it should be quite easy to add methods
to check that a timer has been set.

> TriggerTester doesn't test timer firings
> ----------------------------------------
>
>                 Key: BEAM-694
>                 URL: https://issues.apache.org/jira/browse/BEAM-694
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Eugene Kirpichov
>              Labels: easy, starter
>
> TriggerTester exposes a `fireIfShouldFire(BoundedWIndow)` method. This is used to prompt
a call to the trigger with the current state of the trigger tester (Input Watermarks, elements
present, etc), and see if the trigger should fire.
> The TriggerTester should automatically call back to the trigger with the current state
whenever a Timer fires, as specified by the current watermarks and any Timers set by the trigger
under test. This ensures that Triggers set underlying timers properly, so the trigger will
fire even if no additional elements arrive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message