beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-822) SDK build writes timestamp to source tree, causing spurious builds
Date Wed, 02 Nov 2016 20:18:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15630330#comment-15630330
] 

ASF GitHub Bot commented on BEAM-822:
-------------------------------------

GitHub user dkulp opened a pull request:

    https://github.com/apache/incubator-beam/pull/1265

    [BEAM-822] Move the separate package-info.java compile to java7 profile

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Move the separate package-info.java compile to java7 profile since it's not needed with
java8
    This fixes compiling in Eclipse (assuming Neon which require java8)
    Slightly speeds up Java8 compile (one invoke of compiler plugin)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkulp/incubator-beam eclipse-packageinfo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1265
    
----
commit f6efec86fa6301c166a25316490e65900e46fc3c
Author: Daniel Kulp <dkulp@apache.org>
Date:   2016-11-02T20:14:00Z

    Move the separate package-info.java compile to java7 profile since it's not needed with
java8
    This fixes compiling in Eclipse (assuming Neon which require java8)
    Slightly speeds up Java8 compile (one invoke of compiler plugin)

----


> SDK build writes timestamp to source tree, causing spurious builds
> ------------------------------------------------------------------
>
>                 Key: BEAM-822
>                 URL: https://issues.apache.org/jira/browse/BEAM-822
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Minor
>             Fix For: 0.4.0-incubating
>
>
> The SDK build puts the build timestamp into {{sdk.properties}}. To have a timestamp that
does not break incremental build, the right place for it is in the manifest of the built artifact.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message