beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-833) Exercise Dynamic Splitting in the DirectRunner
Date Wed, 02 Nov 2016 01:12:59 GMT

    [ https://issues.apache.org/jira/browse/BEAM-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627267#comment-15627267
] 

ASF GitHub Bot commented on BEAM-833:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1254

    [BEAM-833] Exercise Dynamic Splitting in the DirectRunner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    For sources that are above a certain size, the DirectRunner will run a
    Thread which will split off half of the remaining work. This exercises
    the concurrent behavior for splitAtFraction and getFractionConsumed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam dynamic_splitting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1254
    
----
commit 4b1549c5e8d7bd759fda2aaae758bb29aa65663a
Author: Thomas Groh <tgroh@google.com>
Date:   2016-11-02T00:23:03Z

    Exercise Dynamic Splitting in the DirectRunner
    
    For sources that are above a certain size, the DirectRunner will run a
    Thread which will split off half of the remaining work. This exercises
    the concurrent behavior for splitAtFraction and getFractionConsumed

----


> Exercise Dynamic Splitting in the DirectRunner
> ----------------------------------------------
>
>                 Key: BEAM-833
>                 URL: https://issues.apache.org/jira/browse/BEAM-833
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-direct
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> This primarily means calling the {{BoundedSource#splitAtFraction}} API during the evaluation
of a BoundedReadEvaluatorFactory - this can return the work via addUnprocessedElements. 
> At a later point, the {{MonitorRunnable}} within {{ExecutorServiceParallelExecutor}}
can examine currently evaluating work and invoke a {{TransformExecutor#split}} method, which
can return to the runner some amount of input, which can be scheduled to use more of the available
threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message