beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-898) BigQueryTornadoes IT has invalid PipelineOptions
Date Mon, 07 Nov 2016 21:31:59 GMT

    [ https://issues.apache.org/jira/browse/BEAM-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645525#comment-15645525
] 

ASF GitHub Bot commented on BEAM-898:
-------------------------------------

GitHub user markflyhigh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1301

    [BEAM-898] Fix Jenkins Build Failure - IT Options Conflicts

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
     - Remove checksum variable in IT Options since it causes conflict between different ITs.
     - only register TestPipelineOptions.class to avoid incompatibility of options defined
in different pipeline.
    
    Test is done by running full set of IT tests on Dataflow service.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam fix-IT-option-issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1301
    
----
commit 0e87f6c2a8a5997c26806283a64d8b812e32b203
Author: Mark Liu <markliu@markliu0.mtv.corp.google.com>
Date:   2016-11-07T19:27:15Z

    Fix IT Options Conflict

----


> BigQueryTornadoes IT has invalid PipelineOptions
> ------------------------------------------------
>
>                 Key: BEAM-898
>                 URL: https://issues.apache.org/jira/browse/BEAM-898
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp, testing
>            Reporter: Daniel Halperin
>            Assignee: Mark Liu
>
> https://builds.apache.org/job/beam_PostCommit_MavenVerify/1718/
> This PR: https://github.com/apache/incubator-beam/pull/1159
> checks that pipeline options cannot have multiple incompatible defaults.
> BigQueryTornadoes ITs have a problem with how they register pipeline options. Luke can
give more details on fix.
> cc [~peihe0@gmail.com] [~lcwik] [~jasonkuster]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message