beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-934) Findbugs doesn't pass in Java8 Examples
Date Mon, 07 Nov 2016 17:50:58 GMT

     [ https://issues.apache.org/jira/browse/BEAM-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Daniel Halperin updated BEAM-934:
---------------------------------
    Description: 
{code}
[INFO] --- findbugs-maven-plugin:3.0.1:check (default) @ beam-examples-java8 ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
[INFO] Total bugs: 2
[INFO] Result of integer multiplication cast to long in org.apache.beam.examples.complete.game.injector.Injector$TeamInfo.getEndTimeInMillis()
[org.apache.beam.examples.complete.game.injector.Injector$TeamInfo] At Injector.java:[line
170]
[INFO] Format string should use %n rather than \n in org.apache.beam.examples.complete.game.injector.InjectorUtils.createTopic(Pubsub,
String) [org.apache.beam.examples.complete.game.injector.InjectorUtils] At InjectorUtils.java:[line
96]
[INFO]      
{code}

  was:
{code}
[INFO] --- findbugs-maven-plugin:3.0.1:check (default) @ beam-examples-java ---
[INFO] BugInstance size is 4
[INFO] Error size is 0
[INFO] Total bugs: 4
[INFO] Possible null pointer dereference in org.apache.beam.examples.complete.TfIdf.listInputDocuments(TfIdf$Options)
due to return value of called method [org.apache.beam.examples.complete.TfIdf, org.apache.beam.examples.complete.TfIdf]
Dereferenced at TfIdf.java:[line 124]Known null at TfIdf.java:[line 124]
[INFO] Bad attempt to compute absolute value of signed 32-bit hashcode in org.apache.beam.examples.complete.TopWikipediaSessions$ComputeTopSessions$1.processElement(DoFn$ProcessContext)
[org.apache.beam.examples.complete.TopWikipediaSessions$ComputeTopSessions$1] At TopWikipediaSessions.java:[line
165]
[INFO] org.apache.beam.examples.complete.TrafficRoutes$StationSpeed defines compareTo(TrafficRoutes$StationSpeed)
and uses Object.equals() [org.apache.beam.examples.complete.TrafficRoutes$StationSpeed] At
TrafficRoutes.java:[line 113]
[INFO] org.apache.beam.examples.cookbook.TriggerExample$InsertDelays.processElement(DoFn$ProcessContext)
uses the nextDouble method of Random to generate a random integer; using nextInt is more efficient
[org.apache.beam.examples.cookbook.TriggerExample$InsertDelays] At TriggerExample.java:[line
479]
[INFO]     
{code}


> Findbugs doesn't pass in Java8 Examples
> ---------------------------------------
>
>                 Key: BEAM-934
>                 URL: https://issues.apache.org/jira/browse/BEAM-934
>             Project: Beam
>          Issue Type: Bug
>          Components: examples-java
>            Reporter: Daniel Halperin
>            Assignee: Davor Bonaci
>
> {code}
> [INFO] --- findbugs-maven-plugin:3.0.1:check (default) @ beam-examples-java8 ---
> [INFO] BugInstance size is 2
> [INFO] Error size is 0
> [INFO] Total bugs: 2
> [INFO] Result of integer multiplication cast to long in org.apache.beam.examples.complete.game.injector.Injector$TeamInfo.getEndTimeInMillis()
[org.apache.beam.examples.complete.game.injector.Injector$TeamInfo] At Injector.java:[line
170]
> [INFO] Format string should use %n rather than \n in org.apache.beam.examples.complete.game.injector.InjectorUtils.createTopic(Pubsub,
String) [org.apache.beam.examples.complete.game.injector.InjectorUtils] At InjectorUtils.java:[line
96]
> [INFO]      
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message