beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1052) UnboundedSource splitId uniqueness breaks if more than one source is used.
Date Tue, 29 Nov 2016 07:54:59 GMT


ASF GitHub Bot commented on BEAM-1052:

GitHub user aviemzur opened a pull request:

    [BEAM-1052] Add InputDStream id to MicrobatchSource hashcode.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Done to avoid collisions between splits of different sources.

You can merge this pull request into a Git repository by running:

    $ git pull add-inputdstream-id-to-microbatchsource-hash-code

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1450


> UnboundedSource splitId uniqueness breaks if more than one source is used.
> --------------------------------------------------------------------------
>                 Key: BEAM-1052
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Aviem Zur
> We use a "running-id" to identify source splits, but we reiterate for each source evaluated.
> Spark already assigns a unique id per InputDStream, it would be unique enough if we replace
{{MicrobatchSource}} hash code with one containing both the running-id and the InputDStream

This message was sent by Atlassian JIRA

View raw message