[ https://issues.apache.org/jira/browse/BEAM-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704575#comment-15704575
]
ASF GitHub Bot commented on BEAM-1052:
--------------------------------------
GitHub user aviemzur opened a pull request:
https://github.com/apache/incubator-beam/pull/1450
[BEAM-1052] Add InputDStream id to MicrobatchSource hashcode.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Done to avoid collisions between splits of different sources.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aviemzur/incubator-beam add-inputdstream-id-to-microbatchsource-hash-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1450.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1450
----
----
> UnboundedSource splitId uniqueness breaks if more than one source is used.
> --------------------------------------------------------------------------
>
> Key: BEAM-1052
> URL: https://issues.apache.org/jira/browse/BEAM-1052
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: Amit Sela
> Assignee: Aviem Zur
>
> We use a "running-id" to identify source splits, but we reiterate for each source evaluated.
> Spark already assigns a unique id per InputDStream, it would be unique enough if we replace
{{MicrobatchSource}} hash code with one containing both the running-id and the InputDStream
id.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|