beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peihe <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1255: [BEAM-59] Use ServiceLoader to register I...
Date Wed, 02 Nov 2016 03:35:19 GMT
GitHub user peihe opened a pull request:

    https://github.com/apache/incubator-beam/pull/1255

    [BEAM-59] Use ServiceLoader to register IOChannelFactories.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peihe/incubator-beam io-channel-register

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1255
    
----
commit 18e204b7a0b90705e4b0fb41093a15341bffb996
Author: Pei He <peihe@google.com>
Date:   2016-11-01T00:58:31Z

    [BEAM-59] Add use Factory interface in Gcs/File/IOChannelFactory.

commit fd940fa32cc96933c85b2cf93306b6572b783d1a
Author: Pei He <peihe@google.com>
Date:   2016-11-01T01:01:41Z

    [BEAM-59] Create IOChannelFactoryFactoryRegistrar interface and its gcs/file implementations.

commit f8b30dda94555e9dada829e7d626a2d3da952804
Author: Pei He <peihe@google.com>
Date:   2016-11-01T01:02:49Z

    [BEAM-59] Use ServiceLoader to register IOChannelFactories in IOChannelUtils.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message