beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #1256: On timer invoker
Date Wed, 02 Nov 2016 03:56:10 GMT
GitHub user kennknowles opened a pull request:

    On timer invoker

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @jkff 
    This comes after #1252 but is otherwise independent. You can review just the additional
    I have a few more thoughts here that I would love feedback on. I am trying to avoid major
overhauls. I will leave my concerns as a self-review so they are contextualized.

You can merge this pull request into a Git repository by running:

    $ git pull OnTimerInvoker

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1256
commit 15a8901ade07c1649378a0b72238eb514877c61c
Author: Kenneth Knowles <>
Date:   2016-11-01T21:48:54Z

    Switch DoFnSignature, etc, from TypeToken to TypeDescriptor

commit 6de216695c05e4d9b283f0842aed8713075be7aa
Author: Kenneth Knowles <>
Date:   2016-11-01T21:50:24Z

    DoFnSignature: Make TypeDescriptor-returning methods public

commit 40bbfff3dba803951607ae15d5d2cf99fbe64a32
Author: Kenneth Knowles <>
Date:   2016-11-01T22:38:01Z

    Add TypeDescriptor#getTypes

commit f2c2f0736d7904474041ed16f782a1c19ca6264e
Author: Kenneth Knowles <>
Date:   2016-11-01T04:30:40Z

    Refactor and reuse parameter analysis in DoFnSignatures

commit a0f5a1521c3b0d8d195f63d15dcc1779640edd8b
Author: Kenneth Knowles <>
Date:   2016-11-02T02:58:35Z

    fixup! use mutable style for contexts

commit aa31ebcfcb51078c39de715c63b01c33f8b0db46
Author: Kenneth Knowles <>
Date:   2016-11-01T02:26:38Z

    Add OnTimerInvoker(s), for invoking DoFn @OnTimer methods
    OnTimerInvoker encapsulates the dispatch from onTimer(<timer ID>)
    to a call to the DoFn method annotated with @OnTimer(<timer ID>).


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message