beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1260: Reduces exposure of WindowedValue in the ...
Date Wed, 02 Nov 2016 18:01:09 GMT
GitHub user jkff opened a pull request:

    https://github.com/apache/incubator-beam/pull/1260

    Reduces exposure of WindowedValue in the SDK

    - Introduces ValueInSingleWindow for purposes of PAssert
    - Moves several classes that should be in runners-core
      and that used WindowedValue, from sdks/ to runners-core:
      KeyedWorkItem stuff and ExecutionContext stuff.
    - Removes deprecated AggregatorFactory which was the only
      remaining compilation blocker after the two above.
    - Moves WindowMatchers{,Test} and PCollectionViewTesting
      to runners-core
    - Uses ValueInSingleWindow in parts of DoFnTester where possible
    
    After this commit, the only places where WindowedValue is exposed in the SDK API surface
are:
    - `WindowingInternals.writePCollectionViewData(TupleTag<?> tag, Iterable<WindowedValue<T>>
data, Coder<T> elemCoder)`
    - Deprecated methods of `PCollectionView` - it should probably be in runners-core, but
I got lost trying to move it there, so I'll defer it to future work. I also don't understand
what these methods do, maybe if they're deprecated there's some easy way to remove them.
    
    R: @kennknowles OR @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam reduce-windowed-value

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1260
    
----
commit 7dd58ed5cb245fc2c6571e9b722aef53c6e590ea
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-10-31T22:46:25Z

    Towards removing WindowedValue from SDK
    
    - Introduces ValueInSingleWindow for purposes of PAssert
    - Moves several classes that should be in runners-core
      and that used WindowedValue, from sdks/ to runners-core:
      KeyedWorkItem stuff and ExecutionContext stuff.
    - Removes deprecated AggregatorFactory which was the only
      remaining compilation blocker after the two above.
    
    After this commit, WindowedValue does not appear in any public
    APIs provided by sdks/.

commit 18548fd9c370349e89e8c5b48e8953ff2576f686
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-10-31T23:33:13Z

    Some more liberation of SDK from WindowedValue
    
    - Moved WindowMatchers{,Test} and PCollectionViewTesting
      to runners-core
    - Used ValueInSingleWindow in parts of DoFnTester where possible

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message