beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <>
Subject [GitHub] incubator-beam pull request #1261: Makes Splittable DoFn in the direct runne...
Date Wed, 02 Nov 2016 18:19:30 GMT
GitHub user jkff opened a pull request:

    Makes Splittable DoFn in the direct runner great again

    - Makes `ProcessFn` be a primitive transform with its own `ParDoEvaluator`. As a nice
side effect, this enables the runner to provide additional hooks into it - e.g. for giving
the runner access to the restriction tracker (in later PRs)
    - For consistency, moves declaration of `GBKIntoKeyedWorkItems` primitive transform into
`SplittableParDo`, alongside the `SplittableProcessElements` transform
    - Adds support for side inputs and outputs to SDF
    - Preserves compressed representation of `WindowedValue`'s in `PushbackSideInputDoFnRunner`
    - Teaches `ProcessFn` to work with exploded windows inside the `KeyedWorkItem`. It works
with them by un-exploding the windows in the `Iterable<WindowedValue<ElementAndRestriction>>`
into a single `WindowedValue`, since the values and timestamps are guaranteed to be the same.
    Tests for new features pending.
    R: @kennknowles @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull enable-sdf

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1261
commit c50b42ccf60ab83f519c550edc2ccd048ed6b213
Author: Eugene Kirpichov <>
Date:   2016-10-26T23:05:01Z

    Stuff compiles


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message