beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1334: Revert "This closes #1315"
Date Thu, 10 Nov 2016 17:11:56 GMT
GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/1334

    Revert "This closes #1315"

    Was merged without checking Jenkins precommits, and in fact breaks precommit testing for
all users.
    
    R: @kennknowles 
    CC: @davorbonaci @tgroh 
    
    I think this is [BEAM-947], but the right fix is to rollback and fix, not rollforward
over multiple days.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam revert-1315

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1334
    
----
commit e005982342704d4039f163573d34dd2cb43ba4b9
Author: Dan Halperin <dhalperi@google.com>
Date:   2016-11-10T17:08:27Z

    Revert "This closes #1315"
    
    This reverts commit 084a5e8aedfdd53f3d76ad48b55a66a282881646, reversing
    changes made to e35f571b0df9e1b74013632c30743a1ddecd3e2a.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message