beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1373: Properly uses result of transform overrid...
Date Wed, 16 Nov 2016 23:49:53 GMT
GitHub user jkff opened a pull request:

    https://github.com/apache/incubator-beam/pull/1373

    Properly uses result of transform override

    Previously direct runner would use the transform override to .apply(),
    but would keep the original transform in the pipeline, e.g. it would use
    the original transform to look up an evaluator.
    
    The current commit makes it use the result of override "for real"
    (including, potentially replacing it further recursively).
    **This change is in DirectRunner.java.**
    
    Additionally, makes InputProvider type-safe (discovered due to a
    run-time ClassCastException that happened while testing the code above).
    **This is the rest of the PR.**
    
    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam apply-transform

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1373
    
----
commit dc89bc614cd38e4daa34bfd6618254874d082265
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-11-16T23:40:08Z

    Properly uses result of transform override
    
    Previously direct runner would use the transform override to .apply(),
    but would keep the original transform in the pipeline, e.g. it would use
    the original transform to look up an evaluator.
    
    The current commit makes it use the result of override "for real"
    (including, potentially replacing it further recursively).
    
    Additionally, makes InputProvider type-safe (discovered due to a
    run-time ClassCastException that happened while testing the code above).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message