beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markflyhigh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1376: Support @ValidatesRunner(RunnableOnServic...
Date Thu, 17 Nov 2016 18:52:24 GMT
GitHub user markflyhigh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1376

    Support @ValidatesRunner(RunnableOnService) in Python [1/2]

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This PR is the half of the work to support @ValidatesRunner(RunnableOnService) test in
Python SDK. Mainly about new nose dependency is introduced.
    
     - Register "--test-options" command line option to nose so that people can run ValidatesRunner
(RunnableOnService) tests with specified pipeline options.
     - Wrap the new command line option as a nose plugin and register it to setuptools. This
avoid unrecognized option error thrown from setuptools.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam support-validate-runner-nose

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1376.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1376
    
----
commit 517406ddc6f8b3dfd4496ff04a4d0e4e64a348b9
Author: Mark Liu <markliu@markliu-macbookpro.roam.corp.google.com>
Date:   2016-11-17T17:53:01Z

    Support @ValidatesRunner(RunnableOnService) in Python [1/2]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message