beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markflyhigh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1382: Support @ValidatesRunner(RunnableOnServic...
Date Thu, 17 Nov 2016 23:02:49 GMT
GitHub user markflyhigh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1382

    Support @ValidatesRunner(RunnableOnService) in Python [2/2]

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
     - Create TestPipeline class which is a wrapper of Pipeline to construct beam pipeline
and will only used in test (ValidatesRunner test and E2E integration test).
     - Provide a small set of examples that how to build ValidatesRunner tests.
     - Currently, the default runner is DirectRunner if it's not specified in command line.
    
    Test done by running all unit test + ValidatesRunner test locally. 
    A subset of ValidatesRunner tests run successfully on Dataflow service.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam support-validate-runner-impl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1382
    
----
commit 835f09bc7ded7ba735e5ba163ac6d7662db0b207
Author: Mark Liu <markliu@markliu-macbookpro.roam.corp.google.com>
Date:   2016-11-17T22:45:42Z

    Support @ValidatesRunner(RunnableOnService) in Python [2/2]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message