beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #1430: [BEAM-498] Remove an OldDoFn and obsolete...
Date Wed, 23 Nov 2016 19:24:55 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-498] Remove an OldDoFn and obsolete WindowingInternals#writePCollectionViewData

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull writePCollectionViewData

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1430
commit d13dd6d4ee4354df876a315097328354320ebba8
Author: Kenneth Knowles <>
Date:   2016-11-23T19:22:08Z

    Remove unused body of StreamingPCollectionViewWriterFn

commit 5144de18bc10c902053cf0cbac41c8cfa8e182a4
Author: Kenneth Knowles <>
Date:   2016-11-23T19:23:07Z

    Remove unused WindowingInternals.writePCollectionViewData


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message