beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sammcveety <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1441: Fix double-close bug
Date Mon, 28 Nov 2016 19:26:51 GMT
GitHub user sammcveety opened a pull request:

    https://github.com/apache/incubator-beam/pull/1441

    Fix double-close bug

    The WritableByteChannel returned for GCS locations has a bug where calling close twice
throws an Exception, so we cannot safely use AutoCloseable here.
    
    R: @davorbonaci 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sammcveety/incubator-beam patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1441
    
----
commit 701c3b46c0d1224e513da2278fd4cbe354cdfa5c
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-11-28T19:26:19Z

    Fix double-close bug
    
    The WritableByteChannel returned for GCS locations has a bug where calling close twice
throws an Exception, so we cannot safely use AutoCloseable here.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message