beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <>
Subject [GitHub] incubator-beam-site pull request #66: Test baseurl presence and fix breaks
Date Fri, 04 Nov 2016 21:11:18 GMT
GitHub user dhalperi opened a pull request:

    Test baseurl presence and fix breaks

    Two commits:
    1. Add baseurl everywhere it's needed
    2. Add tests that will catch future breaks
    The tests use a separate config to set test-specific properties. The `site.url` configuration
specifically does not appear settable from the Jekyll CLI. Unfortunately this means that there
is one property shared between config and test (`.testcontent`)
    Also adds `content` and `.testcontent` to the excludes list so that the builds of each
do not include the other.

You can merge this pull request into a Git repository by running:

    $ git pull baseurl

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
commit 9b25bfd626c049ed92e8e76f69faf766e946ccd8
Author: Dan Halperin <>
Date:   2016-11-04T19:34:04Z

    Add missing site.baseurls

commit 382843539069f62af736dfa3c62babc895ebf12a
Author: Dan Halperin <>
Date:   2016-11-04T20:30:48Z

    Build in a separate content directory to catch bad links


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message