From commits-return-15737-apmail-beam-commits-archive=beam.apache.org@beam.incubator.apache.org Mon Nov 28 20:08:39 2016 Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C3A5919567 for ; Mon, 28 Nov 2016 20:08:39 +0000 (UTC) Received: (qmail 60344 invoked by uid 500); 28 Nov 2016 20:08:39 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 60292 invoked by uid 500); 28 Nov 2016 20:08:39 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 60283 invoked by uid 99); 28 Nov 2016 20:08:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Nov 2016 20:08:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7A52CD6A4A for ; Mon, 28 Nov 2016 20:08:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.018 X-Spam-Level: X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SwKoyQHT5XFH for ; Mon, 28 Nov 2016 20:08:37 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 669625FCEE for ; Mon, 28 Nov 2016 20:08:37 +0000 (UTC) Received: (qmail 50530 invoked by uid 99); 28 Nov 2016 20:06:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Nov 2016 20:06:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BB8E62C03DE for ; Mon, 28 Nov 2016 20:06:58 +0000 (UTC) Date: Mon, 28 Nov 2016 20:06:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-646) Get runners out of the apply() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702974#comment-15702974 ] ASF GitHub Bot commented on BEAM-646: ------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/1442 [BEAM-646] Add Replacement Methods to TransformHierarchy, PValue Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `` in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- These are used as the underlying mechanism for Pipeline Surgery. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam transform_hierarchy_surgery_methods Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1442.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1442 ---- commit 09b46520a6a7baa6bd59e69f7ccccbec86a601b5 Author: Thomas Groh Date: 2016-11-23T02:19:03Z Add Replacement Methods to TransformHierarchy, PValue These are used as the underlying mechanism for Pipeline Surgery. ---- > Get runners out of the apply() > ------------------------------ > > Key: BEAM-646 > URL: https://issues.apache.org/jira/browse/BEAM-646 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Kenneth Knowles > Assignee: Thomas Groh > > Right now, the runner intercepts calls to apply() and replaces transforms as we go. This means that there is no "original" user graph. For portability and misc architectural benefits, we would like to build the original graph first, and have the runner override later. > Some runners already work in this manner, but we could integrate it more smoothly, with more validation, via some handy APIs on e.g. the Pipeline object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)