From commits-return-13566-apmail-beam-commits-archive=beam.apache.org@beam.incubator.apache.org Fri Nov 4 18:12:14 2016 Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA5901935A for ; Fri, 4 Nov 2016 18:12:14 +0000 (UTC) Received: (qmail 49587 invoked by uid 500); 4 Nov 2016 18:12:14 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 49529 invoked by uid 500); 4 Nov 2016 18:12:14 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 49520 invoked by uid 99); 4 Nov 2016 18:12:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2016 18:12:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 51E40C11CC for ; Fri, 4 Nov 2016 18:12:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YRzSzfrz2C3Y for ; Fri, 4 Nov 2016 18:12:13 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 5430F5F3BB for ; Fri, 4 Nov 2016 18:12:13 +0000 (UTC) Received: (qmail 47973 invoked by uid 99); 4 Nov 2016 18:11:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2016 18:11:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 00AF62C2AB6 for ; Fri, 4 Nov 2016 18:11:59 +0000 (UTC) Date: Fri, 4 Nov 2016 18:11:59 +0000 (UTC) From: "Kenneth Knowles (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-694) TriggerTester doesn't test timer firings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Knowles updated BEAM-694: --------------------------------- Component/s: runner-core > TriggerTester doesn't test timer firings > ---------------------------------------- > > Key: BEAM-694 > URL: https://issues.apache.org/jira/browse/BEAM-694 > Project: Beam > Issue Type: Bug > Components: runner-core > Reporter: Eugene Kirpichov > Priority: Minor > Labels: easy, starter > > TriggerTester exposes a `fireIfShouldFire(BoundedWIndow)` method. This is used to prompt a call to the trigger with the current state of the trigger tester (Input Watermarks, elements present, etc), and see if the trigger should fire. > The TriggerTester should automatically call back to the trigger with the current state whenever a Timer fires, as specified by the current watermarks and any Timers set by the trigger under test. This ensures that Triggers set underlying timers properly, so the trigger will fire even if no additional elements arrive. -- This message was sent by Atlassian JIRA (v6.3.4#6332)