From commits-return-13199-apmail-beam-commits-archive=beam.apache.org@beam.incubator.apache.org Wed Nov 2 01:02:38 2016 Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4B11198F1 for ; Wed, 2 Nov 2016 01:02:37 +0000 (UTC) Received: (qmail 61063 invoked by uid 500); 2 Nov 2016 01:02:37 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 60892 invoked by uid 500); 2 Nov 2016 01:02:37 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 60799 invoked by uid 99); 2 Nov 2016 01:02:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 01:02:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BF2DC180AFA for ; Wed, 2 Nov 2016 01:04:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wJxQRrEwDFE3 for ; Wed, 2 Nov 2016 01:04:24 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 40FEF5F2C3 for ; Wed, 2 Nov 2016 01:02:35 +0000 (UTC) Received: (qmail 60406 invoked by uid 99); 2 Nov 2016 01:02:34 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 01:02:34 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9FBCF2C001E for ; Wed, 2 Nov 2016 01:02:34 +0000 (UTC) Date: Wed, 2 Nov 2016 01:02:34 +0000 (UTC) From: "Daniel Halperin (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (BEAM-878) ApiSurfaceTest improvements and reusability MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Daniel Halperin created BEAM-878: ------------------------------------ Summary: ApiSurfaceTest improvements and reusability Key: BEAM-878 URL: https://issues.apache.org/jira/browse/BEAM-878 Project: Beam Issue Type: Improvement Components: testing Affects Versions: Not applicable Reporter: Daniel Halperin Fix For: Not applicable {{ApiSurfaceTest}} in the {{sdks/java/core}} is the class responsible for protecting our public API surface. This test walks the public signatures of all modules and explicitly verifies that everything is on a whitelist. This is how we control what dependencies we expose to our users, so that Beam can keep a tight, stable API surface. We should improve this functionality to be reusable across modules. Some desiderata for reuse: * test automatically infers the module on which it should seed the API search. * only 2 things in the file -- a whitelist and a ~1-line test that passes the whitelist as a parameter to some helper. * test fails if there are things in the whitelist that are not exposed. Any other cool things that are similar to what Maven enforcer does? As an example of what you have to do without this functionality, see https://github.com/apache/incubator-beam/pull/1183 -- This message was sent by Atlassian JIRA (v6.3.4#6332)