From commits-return-13234-apmail-beam-commits-archive=beam.apache.org@beam.incubator.apache.org Wed Nov 2 16:04:03 2016 Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C89319E0F for ; Wed, 2 Nov 2016 16:04:03 +0000 (UTC) Received: (qmail 84798 invoked by uid 500); 2 Nov 2016 16:04:03 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 84746 invoked by uid 500); 2 Nov 2016 16:04:03 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 84737 invoked by uid 99); 2 Nov 2016 16:04:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 16:04:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EB39FC00B6 for ; Wed, 2 Nov 2016 16:04:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 946ck7DUCViy for ; Wed, 2 Nov 2016 16:04:02 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id E69865FC36 for ; Wed, 2 Nov 2016 16:04:00 +0000 (UTC) Received: (qmail 84221 invoked by uid 99); 2 Nov 2016 16:03:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 16:03:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C2DFC2C2ABD for ; Wed, 2 Nov 2016 16:03:59 +0000 (UTC) Date: Wed, 2 Nov 2016 16:03:59 +0000 (UTC) From: "Kenneth Knowles (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-883) Make ApiSurfaceTest fail if something whitelisted is _not_ exposed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Knowles updated BEAM-883: --------------------------------- Priority: Minor (was: Major) > Make ApiSurfaceTest fail if something whitelisted is _not_ exposed > ------------------------------------------------------------------ > > Key: BEAM-883 > URL: https://issues.apache.org/jira/browse/BEAM-883 > Project: Beam > Issue Type: Improvement > Components: testing > Affects Versions: Not applicable > Reporter: Kenneth Knowles > Priority: Minor > Fix For: Not applicable > > > {{ApiSurfaceTest}} in the {{sdks/java/core}} is the class responsible for protecting our public API surface. > This test walks the public signatures of all modules and explicitly verifies that everything is on a whitelist. This is how we control what dependencies we expose to our users, so that Beam can keep a tight, stable API surface. > It fails if anything not whitelisted is exposed. It would be nice if it also something whitelisted is _not_ exposed, to make sure the test stays informative. -- This message was sent by Atlassian JIRA (v6.3.4#6332)