From commits-return-13208-apmail-beam-commits-archive=beam.apache.org@beam.incubator.apache.org Wed Nov 2 03:56:13 2016 Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EFF1F19EBE for ; Wed, 2 Nov 2016 03:56:13 +0000 (UTC) Received: (qmail 45675 invoked by uid 500); 2 Nov 2016 03:56:13 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 45614 invoked by uid 500); 2 Nov 2016 03:56:13 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 45605 invoked by uid 99); 2 Nov 2016 03:56:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 03:56:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1E46E1A006E for ; Wed, 2 Nov 2016 03:56:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.769 X-Spam-Level: X-Spam-Status: No, score=-6.769 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wRC9-LbwZbpW for ; Wed, 2 Nov 2016 03:56:12 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 27EFC5FC84 for ; Wed, 2 Nov 2016 03:56:10 +0000 (UTC) Received: (qmail 45545 invoked by uid 99); 2 Nov 2016 03:56:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 03:56:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 419CAE0A05; Wed, 2 Nov 2016 03:56:10 +0000 (UTC) From: kennknowles To: commits@beam.incubator.apache.org Reply-To: commits@beam.incubator.apache.org Message-ID: Subject: [GitHub] incubator-beam pull request #1256: On timer invoker Content-Type: text/plain Date: Wed, 2 Nov 2016 03:56:10 +0000 (UTC) GitHub user kennknowles opened a pull request: https://github.com/apache/incubator-beam/pull/1256 On timer invoker Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `` in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- R: @jkff This comes after #1252 but is otherwise independent. You can review just the additional commit. I have a few more thoughts here that I would love feedback on. I am trying to avoid major overhauls. I will leave my concerns as a self-review so they are contextualized. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kennknowles/incubator-beam OnTimerInvoker Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1256.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1256 ---- commit 15a8901ade07c1649378a0b72238eb514877c61c Author: Kenneth Knowles Date: 2016-11-01T21:48:54Z Switch DoFnSignature, etc, from TypeToken to TypeDescriptor commit 6de216695c05e4d9b283f0842aed8713075be7aa Author: Kenneth Knowles Date: 2016-11-01T21:50:24Z DoFnSignature: Make TypeDescriptor-returning methods public commit 40bbfff3dba803951607ae15d5d2cf99fbe64a32 Author: Kenneth Knowles Date: 2016-11-01T22:38:01Z Add TypeDescriptor#getTypes commit f2c2f0736d7904474041ed16f782a1c19ca6264e Author: Kenneth Knowles Date: 2016-11-01T04:30:40Z Refactor and reuse parameter analysis in DoFnSignatures commit a0f5a1521c3b0d8d195f63d15dcc1779640edd8b Author: Kenneth Knowles Date: 2016-11-02T02:58:35Z fixup! use mutable style for contexts commit aa31ebcfcb51078c39de715c63b01c33f8b0db46 Author: Kenneth Knowles Date: 2016-11-01T02:26:38Z Add OnTimerInvoker(s), for invoking DoFn @OnTimer methods OnTimerInvoker encapsulates the dispatch from onTimer() to a call to the DoFn method annotated with @OnTimer(). ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---