beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #662: [BEAM-115] WIP: JSON Schema definition of ...
Date Wed, 21 Dec 2016 19:42:14 GMT
GitHub user kennknowles reopened a pull request:

    https://github.com/apache/incubator-beam/pull/662

    [BEAM-115] WIP: JSON Schema definition of pipeline

    This is a json-schema sketch of the concrete schema from the [Pipeline Runner API proposal
document](https://s.apache.org/beam-runner-api). Because our [serialization tech discussion](http://mail-archives.apache.org/mod_mbox/beam-dev/201606.mbox/%3CCAN_Ypr2ZPQG3OgPWu==kF-zztG06k0v5i0AY3DABCHJyvEr9pA@mail.gmail.com%3E)
seemed to favor JSON on the front end and Proto on the backend, I made this quick port. The
original Avro IDL definition is also on [a branch with a test](https://github.com/kennknowles/incubator-beam/blob/pipeline-model/model/pipeline/src/main/avro/org/apache/beam/model/pipeline/pipeline.avdl).
    
    Notes & Caveats:
    - I did not try to flesh out any more details; this was a straight port. There's plenty
to add, but a PR seems like a place that will attract a desired kind of concrete discussion
even in the current state.
    - Typing this makes my hands hurt. Luckily, it should change exceedingly rarely. There
are many libraries that can generate json-schema in various ways, including Jackson itself,
but I'm not so sure any of them are applicable.
    - Reading this makes my eyes hurt. This is a real problem. We need a readable spec, not
just a test suite for validation.
    - I am not so sure that [the schema library](https://github.com/daveclayton/json-schema-validator)
I've used to build my smoke test is a good long term choice. I chose it because it was Jackson-based.
    - I've left comments in the JSON even though that is frowned upon, and taken advantage
of Jackson's feature to allow them. They can also go into `"description"` fields.
    - Perhaps we could write YAML and convert to json-schema with no loss of precision?
    
    Feel free to leave comments here about the schema or meta issues of e.g. where the schema
should live and what libraries we might want to use.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam pipeline-json-schema

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/662.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #662
    
----
commit c5843ce10e782056c76157169eb5516bf18ed9e4
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-10T15:51:02Z

    WIP: add JSON Schema definition of pipeline

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message