beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-27) Add user-ready API for interacting with timers
Date Wed, 21 Dec 2016 04:12:58 GMT


ASF GitHub Bot commented on BEAM-27:

GitHub user kennknowles opened a pull request:

    [BEAM-27] Require TimeDomain to delete a timer

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @aljoscha 
    A bit of an oversight, I neglected the fact that runners generally store different sorts
of timers in rather different ways. When a user sets a timer, the `DoFnSignature` is available,
so this will be for free. And when system code deletes a timer, the domain will always be
    This will require a Dataflow update, so don't worry if Dataflow-specific integration tests
don't pass.

You can merge this pull request into a Git repository by running:

    $ git pull delete-by-domain

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1673
commit 46dfd0fb4d2a1533d3ed053983faee6537d3ccf0
Author: Kenneth Knowles <>
Date:   2016-12-21T04:09:25Z

    Require TimeDomain to delete a timer


> Add user-ready API for interacting with timers
> ----------------------------------------------
>                 Key: BEAM-27
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
> Pipeline authors will benefit from a different factorization of interaction with underlying
timers. The current APIs are targeted at runner implementers.

This message was sent by Atlassian JIRA

View raw message