beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-438) Rename one of PTransform.apply and PInput.apply
Date Fri, 09 Dec 2016 22:31:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736535#comment-15736535
] 

ASF GitHub Bot commented on BEAM-438:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam-site/pull/104

    [BEAM-438] Rename PTransform apply to expand throughout

    The term does not appear to have been used in the running text, so replacement in the
code of the gaming examples is the only change outside of the Javadoc.
    
    This PR should perhaps wait until `0.4.0-incubating` is released, depending on what we
point users to these days.
    
    R: @davorbonaci 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam-site PTransform-expand

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam-site/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit b68b6805960b8c852a6551256827be33054598b9
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-09T22:29:44Z

    Rename PTransform apply to expand throughout

----


> Rename one of PTransform.apply and PInput.apply
> -----------------------------------------------
>
>                 Key: BEAM-438
>                 URL: https://issues.apache.org/jira/browse/BEAM-438
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible
>             Fix For: 0.4.0-incubating
>
>
> Before releasing Beam 1.0, we should do this.
> Right now, it's legal to call:
> {{ptransform.apply(input)}}
> and 
> {{input.apply(ptransform)}}
> when only the latter is correct. The former skips various validation steps and loses
the notion of composite transforms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message