beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-498) Make DoFnWithContext the new DoFn
Date Fri, 16 Dec 2016 23:39:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755809#comment-15755809
] 

ASF GitHub Bot commented on BEAM-498:
-------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/incubator-beam/pull/1648

    [BEAM-498] Undeletes DoFnInvokers.of(OldDoFn)

    In #1565 I deleted some code that's actually necessary to support the Dataflow worker.
Bad idea. We can't delete it until Dataflow worker stops using DoFnInvokers.of(OldDoFn).
    
    R: @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam revert-some-old-dofn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1648
    
----
commit 22f23a70894df213a2bfcf389d3587995b9df9f7
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-12-16T23:26:28Z

    Revert "Removes code for wrapping DoFn as an OldDoFn"
    
    This reverts commit a22de15012c51e8b7e31143021f0a298e093bf51.

commit b8f91349f7c457b878b1d343ae1b20adae955baf
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-12-16T23:26:32Z

    Revert "Removes ArgumentProvider.windowingInternals"
    
    This reverts commit f3e8a0383bf9cb3f9452e0364f7deba113cadff9.

commit 485da3549a53407e8c2a5b6b5cf69740fee68a74
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-12-16T23:37:02Z

    Revert "Moves DoFnAdapters to runners-core"
    
    This reverts commit 33ed3238e2b3899cff061be3056c5cc29fc60a04.

----


> Make DoFnWithContext the new DoFn
> ---------------------------------
>
>                 Key: BEAM-498
>                 URL: https://issues.apache.org/jira/browse/BEAM-498
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message