beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-597) Provide type information from Coders
Date Wed, 07 Dec 2016 20:40:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729854#comment-15729854
] 

ASF GitHub Bot commented on BEAM-597:
-------------------------------------

GitHub user jeremiele opened a pull request:

    https://github.com/apache/incubator-beam/pull/1537

    [BEAM-597] Added a new method on Coder which returns a TypeDescriptor.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The new method allows returning type information about the data being
    encoded and decoded by a Coder.
    Added a default implementation to StandardCoder which returns the
    TypeDescriptor for Object to ease the transition and avoid breaking
    implementations relying on StandardCoder or AtomicCoder.
    
    This will break classes implementing the Coder interface directly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeremiele/incubator-beam add_method_to_coder_for_typedescriptor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1537.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1537
    
----
commit 4a892401689fd01a8318888ff8904e46f917f8f1
Author: Jeremie Lenfant-Engelmann <jeremiele@google.com>
Date:   2016-12-07T19:29:29Z

    Added a new method on Coder which returns a TypeDescriptor.
    
    The new method allows returning type information about the data being
    encoded and decoded by a Coder.
    Added a default implementation to StandardCoder which returns the
    TypeDescriptor for Object to ease the transition and avoid breaking
    implementations relying on StandardCoder or AtomicCoder.
    
    This will break classes implementing the Coder interface directly.

----


> Provide type information from Coders
> ------------------------------------
>
>                 Key: BEAM-597
>                 URL: https://issues.apache.org/jira/browse/BEAM-597
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Jeremie Lenfant-Engelmann
>            Assignee: Jeremie Lenfant-Engelmann
>            Priority: Minor
>
> The Coder interface should return a TypeDescriptor describing the type that is currently
encoded/decoded by the Coder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message