beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-646) Get runners out of the apply()
Date Fri, 02 Dec 2016 22:27:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716726#comment-15716726
] 

ASF GitHub Bot commented on BEAM-646:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1495

    [BEAM-646] Add DirectTestUtils

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Add getGraph(Pipeline) and getProducer(PValue), which use the
    DirectGraphVisitor and DirectGraph methods to provide access to the
    producing AppliedPTransform.
    
    Remove getProducingTransformInternal from everywhere except
    DirectGraphVisitorTest
    
    This removes all remaining uses of `PValue.getProducingTransformInternal`
    from the `DirectRunner`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam producers_consumers_as_datastructure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1495.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1495
    
----
commit 5dc2386be460e004108aeaf89e0b5a5e3c3e50bd
Author: Thomas Groh <tgroh@google.com>
Date:   2016-12-02T18:56:36Z

    Add DirectTestUtils
    
    Add getGraph(Pipeline) and getProducer(PValue), which use the
    DirectGraphVisitor and DirectGraph methods to provide access to the
    producing AppliedPTransform.
    
    Remove getProducingTransformInternal from everywhere except
    DirectGraphVisitorTest

commit a7863cfbdfc8d2289fccdf5499fd245928a11a7d
Author: Thomas Groh <tgroh@google.com>
Date:   2016-12-02T22:26:04Z

    Remove getProducingTransformInternal from DirectGraphVisitorTest

----


> Get runners out of the apply()
> ------------------------------
>
>                 Key: BEAM-646
>                 URL: https://issues.apache.org/jira/browse/BEAM-646
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>
> Right now, the runner intercepts calls to apply() and replaces transforms as we go. This
means that there is no "original" user graph. For portability and misc architectural benefits,
we would like to build the original graph first, and have the runner override later.
> Some runners already work in this manner, but we could integrate it more smoothly, with
more validation, via some handy APIs on e.g. the Pipeline object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message