beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1136) Empty string value should be allowed for ValueProvider<String>
Date Mon, 12 Dec 2016 20:33:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743070#comment-15743070
] 

ASF GitHub Bot commented on BEAM-1136:
--------------------------------------

GitHub user vikkyrk opened a pull request:

    https://github.com/apache/incubator-beam/pull/1580

    [BEAM-1136] Allow empty string value for ValueProvider<String>

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam pipeline_factory_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1580
    
----
commit ba91b3997689d0fc1b4e3ef22b034de8f99310d3
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2016-12-12T20:29:54Z

    Allow empty string value for ValueProvider<String>

----


> Empty string value should be allowed for ValueProvider<String>
> --------------------------------------------------------------
>
>                 Key: BEAM-1136
>                 URL: https://issues.apache.org/jira/browse/BEAM-1136
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Vikas Kedigehalli
>            Assignee: Vikas Kedigehalli
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message