beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1143) Timestamps on Jenkins log lines
Date Mon, 19 Dec 2016 19:43:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762107#comment-15762107
] 

ASF GitHub Bot commented on BEAM-1143:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1659

    [BEAM-1143] More escaping in Jenkins timestamp spec

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The current timestamp spec is insufficiently escaped. The failure mode is that relative
timestamps are shown instead of a readable standard datetime.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam jenkins-timestamps

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1659
    
----
commit 627ccb522d7d818aebe2256246e81af2d3062d11
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-19T19:39:29Z

    More escaping in Jenkins timestamp spec

----


> Timestamps on Jenkins log lines
> -------------------------------
>
>                 Key: BEAM-1143
>                 URL: https://issues.apache.org/jira/browse/BEAM-1143
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>            Reporter: Kenneth Knowles
>            Assignee: Jason Kuster
>            Priority: Minor
>
> I suspect this might be doable more universally in the groovy DSL scripts, but we would
gain some value by a port of https://github.com/apache/incubator-beam/commit/7f82a573d00a5a30331b7bbb8757e55f4a2d93ae
to the most appropriate analog for Jenkins. (in the worst case, just exactly porting the env
var)
> We are currently regularly bottlenecked on build duration/backlog and the time seems
to exist outside of the durations accounted for by Maven's usual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message