beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1146) Decrease spark runner startup overhead
Date Wed, 21 Dec 2016 15:52:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767378#comment-15767378
] 

ASF GitHub Bot commented on BEAM-1146:
--------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/incubator-beam/pull/1674

    [BEAM-1146] Decrease spark runner startup overhead

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Replace finding all `Source` and `Coder` implementations for serialization registration
with wrapper classes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/incubator-beam decrease-spark-runner-startup-overhead

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1674
    
----
commit 8501cdc88ee9c89f643120e34381ec9bc2562965
Author: Aviem Zur <aviemzur@gmail.com>
Date:   2016-12-21T15:49:34Z

    [BEAM-1146] Decrease spark runner startup overhead
    
    Replace finding all `Source` and `Coder` implementations for serialization registration
with wrapper classes.

----


> Decrease spark runner startup overhead
> --------------------------------------
>
>                 Key: BEAM-1146
>                 URL: https://issues.apache.org/jira/browse/BEAM-1146
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-spark
>            Reporter: Aviem Zur
>            Assignee: Aviem Zur
>
> BEAM-921 introduced a lazy singleton instantiated once in each machine (driver &
executors) which utilizes reflection to find all subclasses of Source and Coder
> While this is beneficial in it's own right, the change added about one minute of overhead
in spark runner startup time (which cause the first job/stage to take up to a minute).
> The change is in class {{BeamSparkRunnerRegistrator}}
> The reason reflection (specifically reflections library) was used here is because  there
is no current way of knowing all the source and coder classes at runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message