beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1201) Remove producesSortedKeys from Source
Date Wed, 21 Dec 2016 23:34:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768483#comment-15768483
] 

ASF GitHub Bot commented on BEAM-1201:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/1679

    [BEAM-1201] Remove BoundedSource.producesSortedKeys

    R: @jkff

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam remove-produces-sorted-keys

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1679
    
----
commit ee15138543f8b9926466cf4e4dc6857b3173345e
Author: Dan Halperin <dhalperi@google.com>
Date:   2016-12-21T23:32:38Z

    [BEAM-1201] Remove BoundedSource.producesSortedKeys
    
    Unused and unclear; for more information see the linked JIRA.

----


> Remove producesSortedKeys from Source
> -------------------------------------
>
>                 Key: BEAM-1201
>                 URL: https://issues.apache.org/jira/browse/BEAM-1201
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>            Priority: Minor
>              Labels: backward-incompatible
>
> This is a holdover from a precursor of the old Dataflow SDK that we just failed to delete
before releasing Dataflow 1.0, but we can delete before the first stable release of Beam.
> This function has never been used by any runner. It does not mean anything obvious to
implementors, as many sources produce {{T}}, not {{KV<K,V>}} -- what does it mean in
the former case? (And how do you get the latter case correct?)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message