beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lc...@apache.org
Subject [1/8] beam git commit: [BEAM-1186] Migrated BigtableIOTest to use TestPipeline as a JUnit rule by stabilizing runReadTest's (read) transform name.
Date Wed, 28 Dec 2016 19:41:34 GMT
Repository: beam
Updated Branches:
  refs/heads/master 178371ae3 -> b6944cd62


[BEAM-1186] Migrated BigtableIOTest to use TestPipeline as a JUnit rule by stabilizing runReadTest's
(read) transform name.


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/67ecb0ae
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/67ecb0ae
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/67ecb0ae

Branch: refs/heads/master
Commit: 67ecb0ae23420b2b261fa220997814b47a0f726e
Parents: 9faa5ab
Author: Stas Levin <staslevin@gmail.com>
Authored: Wed Dec 21 23:32:27 2016 +0200
Committer: Luke Cwik <lcwik@google.com>
Committed: Wed Dec 28 11:40:32 2016 -0800

----------------------------------------------------------------------
 .../org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java     | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/67ecb0ae/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java
index e3d1f47..bc71b8c 100644
--- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java
+++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java
@@ -329,9 +329,8 @@ public class BigtableIOTest {
         }));
   }
 
-  private static void runReadTest(BigtableIO.Read read, List<Row> expected) {
-    TestPipeline p = TestPipeline.create();
-    PCollection<Row> rows = p.apply(read);
+  private void runReadTest(BigtableIO.Read read, List<Row> expected) {
+    PCollection<Row> rows = p.apply(read.getTableId() + "_" + read.getKeyRange(), read);
     PAssert.that(rows).containsInAnyOrder(expected);
     p.run();
   }


Mime
View raw message