beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1478: [BEAM-362] Moved KeyedWorkItem and relate...
Date Thu, 01 Dec 2016 04:50:38 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1478

    [BEAM-362] Moved KeyedWorkItem and related classes to runners-core

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @aljoscha would you take a look?
    
    It is just a move of a utility class that I think has no place in the user-facing SDK.
After an initial "LGTM" I will need to do a little dance with the Dataflow runner for integration
tests. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam KeyedWorkItem

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1478
    
----
commit fb0768a943e2586532965d5593ccf8cf6ae11781
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-01T04:46:04Z

    Moved KeyedWorkItem and related classes to runners-core

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message