beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #1541: [BEAM-498] Move PerKeyCombineFnRunner to ...
Date Wed, 07 Dec 2016 22:23:45 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-498] Move PerKeyCombineFnRunner to runners-core

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @peihe seems there is no reason this needs to stay, right? `PerKeyCombineFnRunners`
(the static util class) is already moved.
    R: @lukecwik this has some references to `OldDoFn` so at least this gets them out of the

You can merge this pull request into a Git repository by running:

    $ git pull PerKeyCombineFnRunner

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1541
commit 351f58567212e7a9d4664ca65a0bd4a10a77ed81
Author: Kenneth Knowles <>
Date:   2016-12-07T22:22:21Z

    Move PerKeyCombineFnRunner to runners-core


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message