beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swegner <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1621: Fail to split in FileBasedSource if fileP...
Date Wed, 14 Dec 2016 22:56:21 GMT
GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/1621

    Fail to split in FileBasedSource if filePattern expands to empty

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Typically, input file patterns are validated during Pipeline
    construction, but standard Read transforms include an option to disable
    validation. This is generally useful but can lead to cases where a
    Pipeline executes successfully with empty inputs.
    
    This changes the behavior to fail execution on empty file-based inputs
    even when validation is disabled.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam empty-glob

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1621
    
----
commit 9fc9d66212bf26087622ad6e042db982d5232c55
Author: Scott Wegner <swegner@google.com>
Date:   2016-12-14T22:52:34Z

    Fail to split in FileBasedSource if filePattern expands to empty.
    
    Typically, input file patterns are validated during Pipeline
    construction, but standard Read transforms include an option to disable
    validation. This is generally useful but can lead to cases where a
    Pipeline executes successfully with empty inputs.
    
    This changes the behavior to fail execution on empty file-based inputs
    even when validation is disabled.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message