beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1635: Remove deprecated methods of InMemoryTime...
Date Fri, 16 Dec 2016 00:04:36 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1635

    Remove deprecated methods of InMemoryTimerInternals

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @tweise just choosing reviewer at random
    CC: @scwhittle for the deprecation which I think is now cleaned up
    
    (no JIRA because it is just cleanup)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam remove-deprecated-TimerInternals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1635
    
----
commit e26f4075af6f2c990e23dc9f8fc8be2233652a9f
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-16T00:02:23Z

    Remove deprecated methods of InMemoryTimerInternals

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message