beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1643: [BEAM-362] Move InMemoryTimerInternals to...
Date Fri, 16 Dec 2016 04:52:37 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1643

    [BEAM-362] Move InMemoryTimerInternals to runners-core

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @jkff (I'll grab a committer later, but your contributions are thing affected)
    
    The only substantive aspect of this change is the move of the timer internals directly
into `ProcessFn`. I think this is right or at least the right compromise for many reasons.
    
     - `TimerInternals` is really runner-facing; we don't want that interface in the SDK.
     - Changes to `TimerInternals` incur worker compatibility concerns, so getting it into
runners-core is a win. (I have to change it soon, so I am trying to make my life easier)
     - `DoFnTester` doesn't actually support timers at all, so it didn't make sense for them
to be in there.
     - When `DoFnTester` does support timers, it is trivial to make its own priority queues,
and it will also want to offer greater insight via a richer `TestingTimerInternals` sort of
implementation, which needs not implement the same interface, etc.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam InMemoryTimerInternals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1643.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1643
    
----
commit 5d0bf9895654c12e50410a98347eb9177de00b1d
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-16T04:45:56Z

    Move InMemoryTimerInternals to runners-core

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message