beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #1652: [BEAM-27, BEAM-362] Move InMemoryTimerInt...
Date Sat, 17 Dec 2016 04:44:36 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-27, BEAM-362] Move InMemoryTimerInternals to runners-core; restore a deprecated
copy in its place

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This is a replay of ec0bf7b4023ff75f4ec6723d2e77ed507eb57c51 with an additional adapter
commit that should enable integration tests to succeed.
    Note that this configuration of commits works will with the current capabilities of `git`
and GitHub.  This behavior is not baked into the history, but is calculated dynamically by
both, so it may improve over time.
    Notes on what would happen if this were done in one commit:
     - `git log --follow` finds the history
     - `git diff --find-copies` finds the copy
     - `git blame --find-copies-harder` finds the copy, but `--find-copies` does not
    I don't recall which level GitHub's UI works with, but the most important two are `git
log` and `git blame`. To make sure it works without any of the above, two commits is better.

You can merge this pull request into a Git repository by running:

    $ git pull InMemoryTimerInternals

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1652
commit 6effd6c93587d1c0a02ba9285b47d165ae5c517d
Author: Kenneth Knowles <>
Date:   2016-12-16T04:45:56Z

    Move InMemoryTimerInternals to runners-core

commit 557d2d724c53233ad9d34c9239ff5cf77b754d73
Author: Kenneth Knowles <>
Date:   2016-12-17T04:22:59Z

    Restore SDK's InMemoryTimerInternals, deprecated


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message