beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1660: [BEAM-27] Support setting and deleting ti...
Date Mon, 19 Dec 2016 22:42:24 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1660

    [BEAM-27] Support setting and deleting timers by ID in InMemoryTimerInternals

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This is build on top of the move to runners-core in #1652. Only the second commit contains
nontrivial changes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam InMemoryTimerInternals-dedup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1660
    
----
commit 6effd6c93587d1c0a02ba9285b47d165ae5c517d
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-16T04:45:56Z

    Move InMemoryTimerInternals to runners-core

commit 557d2d724c53233ad9d34c9239ff5cf77b754d73
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-17T04:22:59Z

    Restore SDK's InMemoryTimerInternals, deprecated

commit 0ef0e3a3ecabafdd934f7d03f47f0a220187fb22
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-19T22:01:36Z

    Support set and delete of timer by ID in InMemoryTimerInternals

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message