beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1662: Prune branches in Jenkins build
Date Tue, 20 Dec 2016 04:28:12 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1662

    Prune branches in Jenkins build

    This avoids possible conflicts in evolution of the configuration
    of how remote branches are mapped to local branches.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @jasonkuster 
    
    I believe this would have prevented breakage. Since branches are nothing but pointers,
having them sit around to potentially be incompatible seems to serve no purpose. In other
words, I feel this should be a default configuration, unless someone has a rebuttal.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam jenkins-prune

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1662.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1662
    
----
commit bd6db885836af40940fca20cf680833661180e67
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-20T04:02:48Z

    Prune branches in Jenkins build
    
    This avoids possible conflicts in evolution of the configuration
    of how remote branches are mapped to local branches.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message