beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] beam pull request #1709: [BEAM-1226] Add support for well known coder types ...
Date Wed, 28 Dec 2016 22:01:44 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/beam/pull/1709

    [BEAM-1226] Add support for well known coder types to Apache Beam Python SDK

    This uses specific cloud object representations for the following types:
    kind:pair (TupleCoder with two components, previously pickled)
    kind:stream (IterableCoder with a single component, previously ignored)
    kind:global_window (GlobalWindowCoder, previously SingletonCoder)
    kind:length_prefix (A new type of coder which always encodes the length of the value type
as a prefix, has a single component)
    kind:windowed_value (A wrapper coder with two components (value coder and window coder))
    
    This also drops the ability to configure the timestamp coder on WindowedValueCoder.
    
    These changes are towards having a common binary representation for certain well known
coders across multiple languages.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam well_known_python_coders

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1709.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1709
    
----
commit 6272e296c946311e28f3edc848eaa6caf794ef9d
Author: Luke Cwik <lcwik@google.com>
Date:   2016-12-28T21:54:58Z

    [BEAM-1226] Add support for well known coder types to Apache Beam python SDK
    
    This uses specific cloud object representations for the following types:
    kind:pair (TupleCoder with two components, previously pickled)
    kind:stream (IterableCoder with a single component, previously ignored)
    kind:global_window (GlobalWindowCoder, previously SingletonCoder)
    kind:length_prefix (A new type of coder which always encodes the length of the value type
as a prefix, has a single component)
    kind:windowed_value (A wrapper coder with two components (value coder and window coder))
    
    This also drops the ability to configure the timestamp coder on WindowedValueCoder.
    
    These changes are towards having a common binary representation for certain well known
coders across multiple languages.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message