beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1319) PipelineOptions subclasses defined in the main session could be duplicated
Date Wed, 01 Feb 2017 18:41:52 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848758#comment-15848758
] 

ASF GitHub Bot commented on BEAM-1319:
--------------------------------------

GitHub user aaltay opened a pull request:

    https://github.com/apache/beam/pull/1889

    [BEAM-1319] Add conflict resolution to the PipelineOptions internal argparse.

    In some instances where a PipelineOptions subclass was defined in the
    main session and save_main_session option is enabled, that subclass may
    appear multiple times in the PipelineOptions.__subclassess__() list.
    This is causing problems with the argparse because options are not
    unique any more.
    
    This change filters the subclasses by name, and pick the last unique
    instance of each subclass.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aaltay/beam opt

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1889.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1889
    
----
commit 86c173eb7991594168a53c609747ec6a91651133
Author: Ahmet Altay <altay@google.com>
Date:   2017-02-01T18:39:59Z

    In some instances where a PipelineOptions subclass was defined in the
    main session and save_main_session option is enabled, that subclass may
    appear multiple times in the PipelineOptions.__subclassess__() list.
    This is causing problems with the argparse because options are not
    unique any more.
    
    This changes filter the subclasses by name, and pick the last unique
    instance of each subclass.

----


> PipelineOptions subclasses defined in the main session could be duplicated
> --------------------------------------------------------------------------
>
>                 Key: BEAM-1319
>                 URL: https://issues.apache.org/jira/browse/BEAM-1319
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Ahmet Altay
>
> Duplication is caused as a result of the save_main_session option.
> This also breaks argparse because same options will be defined multiple times.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message