beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aviem Zur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1354) TextIO should comply with PTransform style guide
Date Wed, 08 Feb 2017 03:43:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857335#comment-15857335
] 

Aviem Zur commented on BEAM-1354:
---------------------------------

I've started working on this (locally). 
I've gone ahead with removing the coder from TextIO.
Can this effort be merged?

> TextIO should comply with PTransform style guide
> ------------------------------------------------
>
>                 Key: BEAM-1354
>                 URL: https://issues.apache.org/jira/browse/BEAM-1354
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Aviem Zur
>              Labels: backward-incompatible
>             Fix For: Not applicable
>
>
> * TextIO.Read,Write.Bound,Unbound - Bound,Unbound are banned names. Instead, TextIO should
make the user specify the type parameters explicitly, and have simply TextIO.Read and TextIO.Write
themselves be the transform tyles.
> * Both should take simply String, and not use Coder as a general-purpose serialization
mechanism.
> ** The Javadoc should be changed to reflect this.
> * Should perhaps use AutoValue for parameter builders



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message