beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1492) Avoid potential issue in ASM 5.0
Date Wed, 15 Feb 2017 22:27:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868702#comment-15868702
] 

Kenneth Knowles commented on BEAM-1492:
---------------------------------------

[~amitsela] - our current version of Kryo uses ASM v 4.0 (via reflectasm) which I think is
prior to the bug. To get to ASM 5.1 there is not a version yet released that includes the
fixes; I don't know if it is safe to trust semantic versioning and override 5.0 deps to 5.1
or 5.2.

And the bug may not ever hit us. But I thought I would hand this off to you (or anyone) to
track that we should be careful when upgrading Kryo and possibly just upgrade way past it
as soon as possible.

> Avoid potential issue in ASM 5.0
> --------------------------------
>
>                 Key: BEAM-1492
>                 URL: https://issues.apache.org/jira/browse/BEAM-1492
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Amit Sela
>
> There is a suspected bug in asm 5.0 that is considered the likely root cause of a [bug
sbt-assembly|https://github.com/sbt/sbt-assembly/issues/205#issuecomment-279964607] that carried
over to [GEARPUMP-236]. I have not found a direct reference to what the issue is, precisely,
but the dependency effect of this is extremely small and these are libraries that are useful
to keep current. And if/when Gearpump runner lands on master this will avoid any diamond dep
issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message