beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sbilac <...@git.apache.org>
Subject [GitHub] beam pull request #1918: Fbs2
Date Sat, 04 Feb 2017 19:36:35 GMT
GitHub user sbilac opened a pull request:

    https://github.com/apache/beam/pull/1918

    Fbs2

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sbilac/incubator-beam fbs2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1918.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1918
    
----
commit c796f72f17ccfebcb7961ec5c78eb1649b49f1ec
Author: Slaven Bilac <slaven@google.com>
Date:   2017-01-12T17:26:04Z

    Add support for reading/writing headers to text
    
    files. Footer support is not added since it is not clear
    how to do it for source and not sure about the value it provides.

commit 5e333a2d607352ca7af42fb70edd38e95911665b
Author: Slaven Bilac <slaven@google.com>
Date:   2017-01-12T20:56:45Z

    Fix variable name.

commit 577e7bf8a9710991719a6bea5c3dd8abfd06d69b
Author: Slaven Bilac <slaven@google.com>
Date:   2017-01-16T20:45:42Z

    Addressing CR comments.

commit 75a599f9df6b8717c03b19f3007e6807fd31bab8
Author: sbilac <slaven@google.com>
Date:   2017-01-23T18:45:52Z

    Merge branch 'python-sdk' into fbs2

commit e3e26d602b4f87585cde73ca141d80e3417d8193
Author: Slaven Bilac <slaven@google.com>
Date:   2017-01-24T00:51:35Z

    Fix tests broken by bad merge.

commit 220b322799a212da0a9306efa4d64c54e958d446
Author: Slaven Bilac <slaven@google.com>
Date:   2017-01-25T01:58:57Z

    More cleanup in response to reviewer comments.

commit 3b543f2d0e47a4ee0d2b4cb7436df81a6e7fbe11
Author: Slaven Bilac <slaven@google.com>
Date:   2017-01-25T23:33:20Z

    Merge branch 'python-sdk' of https://github.com/sbilac/incubator-beam into fbs2

commit 6f79f733fdefd7b2010332bb8275450ef3f25fa5
Author: Slaven Bilac <slaven@google.com>
Date:   2017-01-26T00:14:45Z

    Fix lint issues.

commit 85f35833f39dfbad7cfffe83cd1d9b92afad06a8
Author: Slaven Bilac <slaven@google.com>
Date:   2017-02-04T19:26:21Z

    Addressing reviewer feedback.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message